[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs

#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
     Reporter:  dcf          |      Owner:  dcf
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:
    Component:  Flashproxy   |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------

Comment (by infinity0):

 Replying to [comment:12 infinity0]:
 > Replying to [comment:11 dcf]:
 > > I'd like to retain the ability to run the client programs from within
 a source checkout, if possible. Could we put the `flashproxy` package
 directory next to the client programs, the way it ends up with `make
 dist`? Or is that weird from a Python packaging point of view?
 >
 > Yes, this now makes more sense that we are merging fac.py into it too.
 But note that in the pending proposed setup, it is still possible to run
 from checkout with e.g. PYTHONPATH=common ./flashproxy-client. It's not
 unusual for source repos to forgo the ability to run-from-checkout if the
 install process is smooth.

 I just took another look and I don't think this is a good idea now. If we
 have flashproxy/ in the top-level, we also must have setup.py and
 MANIFEST.in in the top-level, plus anything else we might want to add
 later. This would cause some confusion on which files belonged to -client,
 vs -common.

 Are you OK with running things like PYTHONPATH=common ./flashproxy-client?
 To make the process easier I can create a script `init-dev-env` that
 exports this, so you can just do `. ./init-dev-env` then run
 `./flashproxy-client` as normal.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs