[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6810 [Flashproxy]: Reduce code duplication across client programs
#6810: Reduce code duplication across client programs
-----------------------------+--------------------------
Reporter: dcf | Owner: dcf
Type: enhancement | Status: needs_review
Priority: minor | Milestone:
Component: Flashproxy | Version:
Resolution: | Keywords:
Actual Points: | Parent ID:
Points: |
-----------------------------+--------------------------
Comment (by infinity0):
To explain a bit more: I'd like to avoid having two `setup-*.py` scripts
in the same dir. Theoretically, it could work, if we specify different
build directories per script, but this is very fiddly to set up and I'd
like to avoid this headache. Also, after doing some tests, the `install`
target always builds in build/ and you can't override this with `--build-
base` nor `--bdist-base` as you can for the `build` and `bdist` targets.
Practically, we won't actually run into this situation since `setup.py`
only runs py2exe. So if you insist we *could* go down this path, but I
would then insist to rename `setup.py` to `setup-client-exe.py`, to
enforce the fact that these two scripts have distinct functionalities that
have no chance of stepping on each other's toes.
OTOH, one of the other advantages of the common/ and `setup.py develop`
approach is that once you run it, it also works for the facilitator
without having to do anything extra. This is my recommended approach and I
intend to start work on it if I don't hear back soon.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6810#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs