[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12125 [Pluggable transport]: Proposal 232 (TOR_PT_PROXY) support for goptlib

#12125: Proposal 232 (TOR_PT_PROXY) support for goptlib
-------------------------------------+--------------------------
     Reporter:  dcf                  |      Owner:  dcf
         Type:  project              |     Status:  needs_review
     Priority:  normal               |  Milestone:
    Component:  Pluggable transport  |    Version:
   Resolution:                       |   Keywords:  goptlib
Actual Points:                       |  Parent ID:
       Points:                       |
-------------------------------------+--------------------------

Comment (by dcf):

 So a variation on this has been shipping with meek in the 4.0-alpha-1
 bundles. Should we work out the differences between meek's and
 obfs4proxy's implementations and make a patch? Or would you rather expose
 the obfs4 code to battle first?

 Here's meek's implementation (remember that PtGetProxyURL will go away and
 be replaced by a field in ClientInfo):
  * https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/refs/tags/0.10:/meek-client/proxy.go
  * https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/refs/tags/0.10:/meek-client/proxy_test.go
 And here is how you use it:
  * https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/refs/tags/0.10:/meek-client/meek-client.go#l343

 Here's obfs4proxy's implementation:
  *
 https://github.com/Yawning/obfs4/blob/ce39988b11a56e763c8eedbbdab75a35b48366d4/obfs4proxy/pt_extras.go
 And here is how you use it:
  *
 https://github.com/Yawning/obfs4/blob/ce39988b11a56e763c8eedbbdab75a35b48366d4/obfs4proxy/obfs4proxy.go#L196

 I think the main difference is how much validation goptlib should do
 before letting the application see the URL, and what to do in some
 unspecified cases. (I'm leaning to "reject" for the commented test cases
 at https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/refs/tags/0.10:/meek-client/proxy_test.go#l43.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12125#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs