[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #961 [Tor]: TotalTraffic option (upload+download)

#961: TotalTraffic option (upload+download)
-----------------------------+---------------------------------------
     Reporter:  Athaba       |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  minor        |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:  0.2.0.31
   Resolution:  None         |   Keywords:  accounting easy tor-relay
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+---------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Thanks for the patch!  Some quick comments:

  * Instead of doing `log_info(LD_GENERAL, "Weird AccountingRule given,
 defaulting to 'max'");` inside check_reached_limit(), we should probably
 check that AccountingRule is either "max" or "sum" inside options_validate
 in config.c.
  * We should document AccountingRule in doc/tor.1.txt
  * The type of the "limit" needs to be uint64_t, which can be larger than
 'int'
  * I think the calculation in update_expected_bandwidth_usage might need
 to be different for this case too, perhaps.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/961#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs