Re: [tor-bugs] #11679 [Tor]: Download status for consensus scheduled as generic

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#11679: Download status for consensus scheduled as generic
-----------------------------+-------------------------------------------
     Reporter:  cypherpunks  |      Owner:
         Type:  defect       |     Status:  new
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client easy 026-triaged-1
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-------------------------------------------

Comment (by arma):

 Right, this is quite clearly a bug.

 I just looked through the rest of the code and I don't think there are any
 other instances of it -- though we should probably document in or.h when
 we say DL_SCHED_CONSENSUS that we include cert fetches.

 Seems to me that the fix is to either initialize consensus_dl_status with
 {{{
 static download_status_t consensus_dl_status[N_CONSENSUS_FLAVORS] =
   { {0,0,DL_SCHED_CONSENSUS}, {0,0,DL_SCHED_CONSENSUS} };
 }}}
 which will silently become wrong again when we increment
 N_CONSENSUS_FLAVORS and forget to fix it, or have an initialization
 function that walks the array to initialize it. The latter seems wiser?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11679#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs