[tor-bugs] #13119 [Tor]: guidance on tt_ptr_op vs test_eq_ptr()?

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13119: guidance on tt_ptr_op vs test_eq_ptr()?
--------------------+------------------------------------
 Reporter:  arma    |          Owner:
     Type:  defect  |         Status:  new
 Priority:  normal  |      Milestone:  Tor: 0.2.6.x-final
Component:  Tor     |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+------------------------------------
 I'm rebasing andrea's patch from #9262 and I'm updating it to use
 test_eq_ptr() rather than test_eq() when comparing function pointers.

 But in git commit 31f6806aa I see Nick picking {{{tt_ptr_op(v, ==,
 NULL);}}} rather than {{{test_eq_ptr(v, NULL);}}}.

 Is this a style thing? Should we try to be more uniform?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13119>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs