[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13151 [Tor]: OR address is in host order in INTRODUCE2 cell

#13151: OR address is in host order in INTRODUCE2 cell
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-hs tor-client
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by asn):

 Replying to [comment:15 nickm]:
 > I've cherry-picked "bug13151-client" to maint-0.2.4 and merged it
 forward.
 >
 > I have an untested relay-side patch as "bug13151-relay-side-024" in my
 public repository.
 >
 > Currently reviewable branches are my "bug13151-relay-side-024" and
 arma's "bug13151-server-verbose".

 Hello. `bug13151-relay-side-024` looks good to me.

 arma's `bug13151-server-verbose` looks a bit hackish. I don't really like
 the inline code golf
 `((i&0xff)<<24)+((i&0xff00)<<8)+((i&0xff0000)>>8)+((i>>24)&0xff)` . It
 also adds a `log_notice()` to the code.

 I also noticed that both of your branches implement very similar
 functionality (reverse received addr and compare with relay addr, if they
 match reverse received addr ). I wonder if it can get funcionified (and
 even unittested).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13151#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs