Re: [tor-bugs] #13161 [Chutney]: [patch] getting chutney working with tor 0.2.6-alpha on OS X

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#13161: [patch] getting chutney working with tor 0.2.6-alpha on OS X
-------------------------+-----------------------------------
     Reporter:  teor     |      Owner:  nickm
         Type:  defect   |     Status:  needs_revision
     Priority:  normal   |  Milestone:
    Component:  Chutney  |    Version:  Tor: unspecified
   Resolution:           |   Keywords:  tor-authority chutney
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-----------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Hmmm.  A few general notes:

   * Would you be able to generate future patches with "git format-patch"
 rather than "git diff" or whatever you're doing now?  If you use "git
 format-patch", I can merge them directly with "git am" and I don't need to
 re-enter the commit messages.
   * For future patches with changes to Tor, could you write a changelog
 fragment file for the "changes" directory, as described in doc/HACKING?
 That'll also make it faster for me to apply patches.

 Patch-by-patch:
   * 01 looks okay, but the option needs to be documented in doc/tor.1.txt
   * 02 will break chutney with older versions of Tor.  This happens every
 time we add a new option and have chutney use it.  I wonder if we could
 make chutney smarter about which options to include depending on which
 version of Tor it's configuring to use.
   * 03 looks fine
   * 04 looks fine
   * 05 looks okay; I wonder if chutney should do this kind of thing itself
 if it's about to overwrite a running network.
   * 06 looks fine
   * 07 looks fine
   * 08 looks fine
   * 09 looks fine; I agree that if we're goign to merge it, though, it
 should be an option or something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13161#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs