Re: [tor-bugs] #12971 [Tor]: Invalid SOCKS5 response to UDP associate request

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12971: Invalid SOCKS5 response to UDP associate request
-----------------------------+--------------------------------
     Reporter:  yurivict271  |      Owner:  rl1987
         Type:  defect       |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-client, easy
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by yawning):

 * status:  needs_review => needs_revision


Comment:

 Looks much better now.  Some minor thoughts.
  * I would personally prefer if the function name included the socks
 version, as the code supports both socks 4 and socks 5, so it's
 immediately obvious when skimming the code.
  * The socks code has unit tests.  It would be nice if the test was
 updated for this change.
 `test_socks.c:test_socks_5_unsupported_commands()` would be the function
 to edit, and even has helpful comments reflecting the old broken behavior.

 Apart from those things, looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12971#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs