Re: [tor-bugs] #16963 [Tor Browser]: When we are not on a tag, TORBROWSER_BUILDDIR includes the wrong commit hash

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#16963: When we are not on a tag, TORBROWSER_BUILDDIR includes the wrong commit
hash
---------------------------+-----------------------------------------------
     Reporter:  boklm      |      Owner:  boklm
         Type:  defect     |     Status:  needs_review
     Priority:  normal     |  Milestone:
    Component:  Tor        |    Version:
  Browser                  |   Keywords:  TorBrowserTeam201509R, tbb-gitian
   Resolution:             |  Parent ID:
Actual Points:             |
       Points:             |
---------------------------+-----------------------------------------------
Changes (by boklm):

 * status:  new => needs_review
 * keywords:  TorBrowserTeam201509 => TorBrowserTeam201509R, tbb-gitian


Comment:

 I attached a patch to fix this.

 Without the patch:
 {{{
 $ git show -s --oneline
 fb4e9c0b57e7 Point detailsURL to our blog
 $ ./get-tb-version alpha
 TORBROWSER_VERSION=5.5a2
 TORBROWSER_BUILDDIR=5.5a2-005158dcefdd
 TORBROWSER_SYMLINK_VERSION=0
 }}}

 With the patch:
 {{{
 $ git show -s --oneline
 b4465b0552ba Bug 16963: use the right commit hash in TORBROWSER_BUILDDIR
 $ ./get-tb-version alpha
 TORBROWSER_VERSION=5.5a2
 TORBROWSER_BUILDDIR=5.5a2-b4465b0552ba
 TORBROWSER_SYMLINK_VERSION=0
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16963#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs