[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16937 [Tor Browser]: The browser.startup.homepage pref has been translated in the Korean bundle
#16937: The browser.startup.homepage pref has been translated in the Korean bundle
-----------------------------+-----------------------------------
Reporter: boklm | Owner: tbb-team
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor Browser | Version:
Resolution: | Keywords: TorBrowserTeam201509R
Actual Points: | Parent ID:
Points: |
-----------------------------+-----------------------------------
Comment (by gk):
Replying to [comment:4 mcs]:
> It turns out that the default values for browser.startup.homepage and
spellchecker.dictionary cannot be directly placed in a prefs file (such as
defaults/preferences/
> preferences.js within Torbutton). This is because the browser retrieves
them using the getComplexValue() prefs API. So we must continue to use a
level of indirection to a properties file.
Given that a lot of our branding is in tor-browser/branding/official
(icons for exmaple) and this is the place Mozilla has for such general,
browser related things: what speaks against patching
locales/browserconfig.properties to point to `about:tor` instead of
`about:home`? This would leave all the implementation of that hompegae in
Torbutton (which is fine to me), would use the same mechanism Mozilla has
for these things, would omit an additional file in Torbutton and, above
all, would avoid the localization problem.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16937#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs