[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17009 [Tor Browser]: Shift and Alt keys leak physical Keyboard layout

#17009: Shift and Alt keys leak physical Keyboard layout
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  arthuredelstein        |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting,
  Browser                |  TorBrowserTeam201509R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:3 cypherpunks]:
 > This patch seems insufficient. getModifierState could be used polling
 the keyboard.
 >
 > There are a lot more modifiers that can leak information:
 > https://developer.mozilla.org/en-
 US/docs/Web/API/KeyboardEvent/getModifierState

 You're right -- thanks for catching this. Here's a new version of the
 patch that ensures that `KeyboardEvent.getModifierState("Alt") ===
 KeyboardEvent.altKey` and `KeyboardEvent.getModifierState("Shift") ===
 KeyboardEvent.shiftKey`.

 https://github.com/arthuredelstein/tor-browser/commit/17009+1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17009#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs