[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19043 [Core Tor/Tor]: prop224: Implementation of ESTABLISH_INTRO cell

#19043: prop224: Implementation of ESTABLISH_INTRO cell
-------------------------------------------------+-------------------------
 Reporter:  alec.heif                            |          Owner:
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, 6.s194,             |  Actual Points:
  TorCoreTeam201609                              |
Parent ID:  #17241                               |         Points:  3
 Reviewer:  asn, dgoulet                         |        Sponsor:
                                                 |  SponsorR-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Hello there friends,

 I'm happy to push the first revision of code that handles prop224
 ESTABLISH_INTRO cells. I started with MIT Alec's branch as a base, but
 most of
 the code has since been rewritten. All errors mine, etc.

 You can find the code in branch `bug19043_v1` in my repo.
 Here is a gitlab link as well: https://gitlab.com/asn/tor/merge_requests/3

 A few words about the branch:

 First of all, it's based on David's #20004 branch which adds all the
 relevant
 trunnel definitions. It then introduces some functions that will come
 handy
 later when we handle v3 ESTABLISH_INTRO cells.  The biggest addition here
 is
 the HS circuitmap subsystem which maps introduction tokens to circuits.
 The
 branch then proceeds with functions that generate and handle
 ESTABLISH_INTRO
 cells, which is the main contribution.  Finally, it adds tests for
 handling
 both v2 and v3 ESTABLISH_INTRO cells.

 There are some XXXs sprinkled around the code aimed towards early
 reviewers.
 Please browse through them as most of them should be resolved before we
 reach
 the final review stages :)

 WRT unittest LoC coverage:
     {{{
     hs_circuitmap.c : 100.00%
     hs_intropoint.c : 80.95%
     hs_service.c    : 80.39%
     }}}
 The numbers here will improve further upon resolving some of the XXXs.

 David, feel free to grab the code mutex here if you feel like it. :)

 Cheers!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19043#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs