[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #19016 [Metrics/CollecTor]: add shutdown hook
#19016: add shutdown hook
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: enhancement | Status: needs_revision
Priority: Low | Milestone: CollecTor 1.1.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: ctip | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Comment (by iwakeh):
Thanks, for the suggestions!
I think there is no way to catch a second `kill` signal; the shutdown
thread is only called once by the jvm.
The 20 min waiting time is pretty arbitrary and could only be fully used
by relaydesc module anyway, afaict.
I thought that it should accommodate a just started relaydesc download to
finish properly to make sense.
Maybe this grace period should be made configurable to give operators
better control?
Please review
[https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19016
-shutdown-hook&id=7cec1c874adffd14b7f152e289a0ccdc7cac7ad5 my branch] with
the additional log-stmt and w/o the redundant imports (Thanks for spotting
these!);
and
[https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-19016
-shutdown-hook&id=cb78f5fe5b30dc138bb545c8f26b95b7abc90d9d another commit]
with a configurable grace period.
With the configurable grace period the change log needs to be adapted
otherwise it's fine.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19016#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs