[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #19934 [Metrics/CollecTor]: CollecTor should use new metrics-lib json classes

#19934: CollecTor should use new metrics-lib json classes
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.1.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Without having reviewed the patch in detail, I'm worried about using types
 from metrics-lib's `org.torproject.descriptor.index` package which are
 still in alpha stage.  Should we rather try to hide the details from
 CollecTor by providing a `DescriptorIndexGenerator` interface that takes a
 directory as input as well as a list of desired file extensions and that
 produces `index.json*` files accordingly?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19934#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs