[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17178 [Core Tor/Tor]: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
#17178: Rendezvous Single Onion Services: One-Hop Intro Point and Rendezvous
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: enhancement | Status:
| needs_review
Priority: High | Milestone: Tor:
| 0.2.9.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rsos, tor-hs, TorCoreTeam201608, | Actual Points: 13.5
TorCoreTeam201609, review-group-5, review- |
group-8 |
Parent ID: | Points: 6.5
Reviewer: nickm | Sponsor:
-------------------------------------------------+-------------------------
Comment (by teor):
I have thought of some minor changes that could clarify our dual-option
design, but I don't think they're that necessary (and I have patch
fatigue!):
* Refactor options_validate_single_onion() to use
rend_service_non_anonymous_mode_enabled() and
rend_service_allow_non_anonymous_connection(), rather than the raw options
* Whenever we use one of rend_service_non_anonymous_mode_enabled() or
rend_service_allow_non_anonymous_connection(), assert it's equal to the
other
* except in options_validate_single_onion(), where they're allowed to be
different
* Use rend_service_allow_non_anonymous_connection() for the places where
we are specifically deciding to make a one-hop connection, and
rend_service_non_anonymous_mode_enabled() otherwise (for example, when
poisoning or checking ADD_ONION flags)
Do you think these would be useful, nickm?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17178#comment:84>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs