[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20148 [Core Tor/Tor]: Add AES256 support to crypto_cipher_t

#20148: Add AES256 support to crypto_cipher_t
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  crypto        |  Actual Points:  .2
Parent ID:                |         Points:  .2
 Reviewer:                |        Sponsor:  SponsorR-can
--------------------------+------------------------------------
Changes (by dgoulet):

 * keywords:   => crypto
 * status:  needs_review => needs_information


Comment:

 Global observation. If the goal is to keep this change as minimal as
 possible, I guess the current code is fine.

 However, I see that we have `crypto_cipher_new()` that only does 128 bits.
 Then we have `crypto_cipher_new_with_iv()` that also only does 128 bits
 and then this new one `crypto_cipher_new_with_bits()` (and the with_iv)
 that we can control the bits.

 Wouldn't be simpler to have all `crypto_cipher_new*` to take a bit size?
 Would make the entire API more symmetric. I see very few callsites of
 those, actually 6 outside of crypto.c.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20148#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs