[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20070 [Core Tor/Tor]: Make address choice failure log message more informative
#20070: Make address choice failure log message more informative
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| 0.2.9.x-final
Component: Core Tor/Tor | Version: Tor:
| 0.2.8.1-alpha
Severity: Normal | Resolution:
Keywords: CoreTorTeam201609, ipv6, review- | Actual Points: 0.2
group-9 |
Parent ID: | Points: 0.2
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
* reviewer: => dgoulet
Comment:
Quick questions. Only ipv6, not v4?
{{{
+ /* If an authority or fallback directory has a hard-coded IPv6
address,
+ * but we receive a descriptor without that address, Tor will believe
the
+ * descriptor, and end up here. */
}}}
Also, why don't we backtrace in the case of the hard-coded rs?
Else lgtm; Feel free to `merge_ready` this if the you believe my questions
don't need code modification.
actual-review-points: 0.1
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20070#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs