[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17904 [Applications/Tor Browser]: Use sufficient window dimensions in Privacy and Security Settings

#17904: Use sufficient window dimensions in Privacy and Security Settings
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Low                                  |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  tbb-security-slider,                 |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  SponsorU
-------------------------------------------------+-------------------------

Comment (by mcs):

 Kathy and I reviewed this and it looks good. We have just a couple of
 comments:
 1. You added ids to many XUL elements, but we do not see where they are
 used. Are they needed? For example, you added `id="privacy_checkboxes"`
 Are these IDs needed?
 2. The preferences.xul file has no tabs except for one (which should
 probably be removed). Please use spaces instead of tabs to stay consistent
 with the rest of the file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17904#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs