[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20030 [Obfuscation/meek]: meek-http-helper doesn't shutdown cleanly in 6.5a1
#20030: meek-http-helper doesn't shutdown cleanly in 6.5a1
------------------------------+------------------------------
Reporter: arlolra | Owner: dcf
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Obfuscation/meek | Version:
Severity: Normal | Resolution:
Keywords: regression | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
------------------------------+------------------------------
Changes (by dcf):
* keywords: => regression
* status: new => needs_review
Comment:
attachment:0001-Ignore-SIGPIPE-in-meek-client-torbrowser.patch works
around the problem by ignoring SIGPIPE. I found I had to call
signal.Notify with a dummy channel; calling signal.Ignore didn't work.
I think we're fine with ignoring logging errors. The log package ignores
them anyway. I'm a bit worried that because Go's SIGPIPE rule affects both
stdin and stdout, something might go wrong with the PT negotiation on
stdout. goptlib doesn't report errors that may arise from its writes to
stdout. But I couldn't think of a way it would cause a problem, and even
if it does it should be rare.
arlolra, if you want to test this, you can just `go build` in the meek-
client-torbrowser subdirectory, then copy meek-client-torbrowser into your
bundle directory.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20030#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs