[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23355 [Core Tor/Tor]: prop224: Implement a client purge state for NEWNYM
#23355: prop224: Implement a client purge state for NEWNYM
-----------------------------+------------------------------------
Reporter: dgoulet | Owner: (none)
Type: enhancement | Status: needs_review
Priority: High | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: prop224, tor-hs | Actual Points:
Parent ID: #23300 | Points:
Reviewer: asn | Sponsor:
-----------------------------+------------------------------------
Comment (by asn):
Patch looks good. One thing makes me anxious: We call
`DIGEST256MAP_FOREACH_MODIFY` on so many digestmaps without first checking
that they are not-NULL. I don't think the `foreach` functions check for
NULL before iterating which might cause segfaults. Shouldn't we check that
the maps are non-NULL?
Other than that, LGTM.
Feel free to fix the above or not and then mark it as `merge_ready`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23355#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs