[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21759 [Metrics/CollecTor]: Add persistence for torperf/onionperf

#21759: Add persistence for torperf/onionperf
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.4.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by iwakeh):

 Replying to [comment:15 karsten]:
 > Alright, I finally reviewed your
 [https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-21759-2
 task-21759-2 branch]. Here's what I found:
 >
 >  - The case changes to configuration options (like `"OnionperfActivated"
 -> "OnionPerfActivated"`) deserve a change log entry under "Major
 changes", unless we don't care about case there. Because if we do we'll
 have to inform operators that they'll need to update their configurations.

 Indeed, that is important and should go in the Major-section!  Besides the
 changelog I will also highlight this in the announcement.

 >  - We'll need to put out metrics-lib 2.1.0 before merging at least the
 last commit(s) in your branch. Should we 1) push that forward to get this
 branch merged, 2) merge only commits from this branch that don't require
 m-lib 2.1.0, or 3) put this branch on hold until 2.1.0 is out?

 Just merge all now.  We have releases, thus master can depend on some
 unreleased metrics-lib dev-version, that's fine.  And, other tickets will
 need metrics-lib-2.1.0, too.  We only need to make sure that metrics-lib
 2.1.0 is out before we release CollecTor again.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21759#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs