Re: [tor-bugs] #23331 [Core Tor/Tor]: prop224: Don't build HS desc if we don't have a live consensus

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23331: prop224: Don't build HS desc if we don't have a live consensus
--------------------------+------------------------------------
 Reporter:  asn           |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  prop224       |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:  SponsorR-can
--------------------------+------------------------------------
Changes (by asn):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:3 nickm]:
 > I agree with adding the check in hs_service_callback(), but I'm not sure
 it makes sense to remove the one in should_service_upload_descriptor().
 It's a cheap thing to check, and it protects us in case we start calling
 should_service_upload_descriptor() from anywhere else in the codebase.


 Sounds good to me. Fixup pushed in my `bug23331_032_01`.
 Back in `merge_ready`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23331#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs