[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs
#23215: set annotation from descriptor during sync-runs
-------------------------------+---------------------------------
Reporter: iwakeh | Owner: iwakeh
Type: defect | Status: merge_ready
Priority: Medium | Milestone: CollecTor 1.3.0
Component: Metrics/CollecTor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+---------------------------------
Changes (by iwakeh):
* status: needs_review => merge_ready
Comment:
I added a little more test variety and the changelog entry as
[https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-23215
another commit to the above branch].
Regarding the nitpick: I find it easier to distinguish between "anno" and
annos" than "annotation" and "annotations"; in general very long variable
names feel/look like cluttering. I changed a few occurrences, but would
not want to make it a rule. Anyway, there are all these 'sb', 'is',
'bais', etc. all over the codebases. It is true though, that 'anno' might
be misunderstood as year.
Setting this to merge ready as I only made very minor changes. Please
check again before merging.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23215#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs