[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #23467 [Metrics/Onionoo]: running parameter vs. field mismatch
#23467: running parameter vs. field mismatch
---------------------------------+--------------------------
Reporter: cypherpunks | Owner: metrics-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Metrics/Onionoo | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
---------------------------------+--------------------------
https://lists.torproject.org/pipermail/metrics-
team/2017-September/000456.html
{{{
It might be that we're using two different definitions for "running":
- The "running=false" parameter checks whether a bridge is contained in
the latest known status *and* has the "Running" flag assigned.
https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/writer/SummaryDocumentWriter.java#n83
- The "running" field in details documents only checks whether a bridge
is contained in the latest known status but ignores whether it got the
"Running" flag there or not.
https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java#n866
We should probably use the first definition and also require the
"Running" flag before calling a bridge "running".
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23467>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs