[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23231 [Applications/Tor Browser]: Error in STL wrappers when building Firefox 64-bit for Windows
#23231: Error in STL wrappers when building Firefox 64-bit for Windows
--------------------------------------+--------------------------
Reporter: boklm | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201709 | Actual Points:
Parent ID: #23229 | Points:
Reviewer: | Sponsor: Sponsor4
--------------------------------------+--------------------------
Comment (by cypherpunks):
There are too much issues, so just random thoughts:
First of all, https://dxr.mozilla.org/mozilla-esr52/source/config/gcc-stl-
wrapper.template.h should be updated with all the fixes as msvc- one.
Do we need https://hg.mozilla.org/mozilla-central/rev/491c4ae1ea4a?
But, generally, read https://bugzilla.mozilla.org/show_bug.cgi?id=427107 -
they almost don't test paths without jemalloc :(
Also, there is
{{{
// MinGW doesn't appropriately inline these functions in debug builds,
// so we need to do some extra coercion for it to do so. Bug 1332747
}}}
instead of reading
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/gcc/Inline.html (it's short)
There is an assumption that they didn't take into consideration mingw-w64
when they did https://bugzilla.mozilla.org/show_bug.cgi?id=868814.
But this error is about visibility (MOZ_EXPORT) and not inlining (but
`-fno-keep-inline-dllexport` may affect this).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23231#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs