Re: [tor-bugs] #23480 [Core Tor/Tor]: hs: Rate limit some logs in hs-v3 subsystem

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23480: hs: Rate limit some logs in hs-v3 subsystem
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  (none)
     Type:  defect           |         Status:  assigned
 Priority:  Low              |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  dgoulet          |        Sponsor:
-----------------------------+------------------------------------

Comment (by dgoulet):

 I would also fix a logging statement in `hs_cache.c` in the process with
 this ticket.

 {{{
        char key_b64[BASE64_DIGEST256_LEN + 1];
        base64_encode(key_b64, sizeof(key_b64), (const char *) key,
                      DIGEST256_LEN, 0);
        log_info(LD_REND, "Removing v3 descriptor '%s' from HSDir cache",
                 safe_str_client(key_b64));
 }}}

 ... which prints garbage as the base64 value. We should use
 `digest256_to_base64()` here and I confirm it works.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23480#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs