Re: [tor-bugs] #22871 [Obfuscation/BridgeDB]: Implement backend for moat

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#22871: Implement backend for moat
----------------------------------------+----------------------
 Reporter:  isis                        |          Owner:  isis
     Type:  enhancement                 |         Status:  new
 Priority:  High                        |      Milestone:
Component:  Obfuscation/BridgeDB        |        Version:
 Severity:  Normal                      |     Resolution:
 Keywords:  SponsorM, bridgedb-captcha  |  Actual Points:
Parent ID:                              |         Points:  3
 Reviewer:                              |        Sponsor:
----------------------------------------+----------------------

Comment (by isis):

 Replying to [comment:5 mcs]:
 > Replying to [comment:2 isis]:
 > > A first draft spec of the API is
 [https://github.com/isislovecruft/bridgedb/tree/fix/22871#accessing-the-
 moat-interface here].  Please review!  I'm finishing up the implementation
 of #15967 and then I'll get starting on implementing this spec.
 >
 > This looks pretty good. Kathy isn't here right now, but I will ask her
 to take a look later. I have just a couple of comments:
 > 1. I am not a fan of the verbose `type` strings, e.g., `moat client
 supported transports`. Maybe this is a JSON-API style thing, but I would
 rather use shorter, easier to compare strings such as `'type': 'client-
 transports'`.

 Sure, I can go shorter with hyphenations. I honestly didn't know what to
 put there, so I just made stuff up. I'll update it.

 > 2. (you asked about this on IRC) The error response seems okay, although
 if there are distinct reasons for failure that would be helpful for end-
 users to know, please add enumerated error codes that Tor Launcher can use
 to pull out a localized string. The way things are now, Tor Launcher will
 probably not use the `title` or `details` field in the UI; maybe just log
 them (because we don't want to show English text to people who speak other
 languages).

 That makes sense, I'll keep the spec updated and use different error codes
 if I think of any cases where it might make sense to localise.  (As of
 right now it seems more useful to log these kinds of errors on the
 BridgeDB server and in the browser console.)

 > p.s. I like the 419 status string :)

 Yeah! It's pretty great. It was nickm's idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22871#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs