Re: [tor-bugs] #23499 [Core Tor/Tor]: dir server responses should include a Date: header even when not responding 200

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23499: dir server responses should include a Date: header even when not responding
200
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  merge_ready
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  clock-skew    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by arma):

 * status:  needs_review => merge_ready


Comment:

 Your patches look good! Thanks. (check-spaces might have something to say
 to you.)

 (I spent a little while thinking about whether we could refactor the
 "write the status code and date header" part out to its own thing, since
 write_http_response_header_impl() essentially do that too, but I didn't
 hit upon a satisfactory way. If you find one, please feel free. :)

 Oh, and as for whether dcd0aea8 is unnecessary, look right below it to
 where we
 {{{
   log_debug(LD_DIRSERV,"Wrote status 'HTTP/1.0 %d %s'", status,
 reason_phrase);
 }}}
 That's the log I meant.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23499#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs