[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23039 [Applications/Tor Browser]: Make the rbm build system work with runc 1.0.0



#23039: Make the rbm build system work with runc 1.0.0
--------------------------------------------+------------------------
 Reporter:  boklm                           |          Owner:  boklm
     Type:  task                            |         Status:  closed
 Priority:  Low                             |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:  fixed
 Keywords:  tbb-rbm, TorBrowserTeam201709R  |  Actual Points:
Parent ID:  #17379                          |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:4 boklm]:
 > Replying to [comment:3 gk]:
 > > Pointing to https://github.com/opencontainers/runtime-
 spec/commit/eb114f057094dd2314682d55f8cb9c189915ac86 shows the
 reformatting of the capabilities. But why do we suddenly need so many more
 compared to `runc` < 1.0.0. The commit you pointed to does not make this
 kind of change.
 >
 > Actually we use the same list of capabilities as before, but we now need
 to list separately the bounding, effective, inheritable, permitted and
 ambient capabilities, instead of having just one list before. I updated
 the commit message to say that.

 Indeed, sorry. My bad, but thanks for making this more explicit.

 > >
 > > The `needs_revision` is for missing changes to `README` as runc 0.1.1
 is not required anymore with this patch.
 >
 > I removed the part about the runc version from the README in branch
 `bug_23039_v2`:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_23039_v2&id=209818fc10ba14e8ebfb126cc364c26300795af9

 Applied to `master` (commit 209818fc10ba14e8ebfb126cc364c26300795af9).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23039#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs