Re: [tor-bugs] #23500 [Core Tor/Tor]: check-spaces.pl should check spaces after a comma when in functions.

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23500: check-spaces.pl should check spaces after a comma when in functions.
--------------------------+------------------------------------
 Reporter:  ewong         |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  code-style    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:5 ewong]:
 > Do you want me to do this in the same pr or a different one?

 Same pr and branch is fine, but a different commit.

 Usually we do mass replaces using a script, and then put that script in
 the commit.
 That way someone can verify that commit only contains the results of the
 script.

 For example, a script for this might be something like:
 `sed 's/,([^ ])/, \1/'`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23500#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs