[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22343 [Applications/Tor Browser]: Save as... in the context menu results in using the catch-all circuit

#22343: Save as... in the context menu results in using the catch-all circuit
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-linkability, ff52-esr,           |  Actual Points:
  tbb-7.0-must, tbb-7.0-issues, tbb-regression,  |
  tbb-7.0-frequent, TorBrowserTeam201709         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:
     tbb-linkability, ff52-esr, tbb-7.0-must, tbb-7.0-issues, tbb-
     regression, tbb-7.0-frequent, TorBrowserTeam201709R
     =>
     tbb-linkability, ff52-esr, tbb-7.0-must, tbb-7.0-issues, tbb-
     regression, tbb-7.0-frequent, TorBrowserTeam201709
 * status:  needs_review => needs_revision


Comment:

 The patch still breaks things. If you take
 https://developer.mozilla.org/samples/video/chroma-key/index.xhtml and
 right-click on the image choosing the "Save image as..." option you get a
 {{{
 A coding exception was thrown in a Promise resolution callback.
 See
 https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

 Full message: TypeError: this.principal is undefined
 Full stack:
 nsContextMenu.prototype.saveMedia/<@chrome://browser/content/nsContextMenu.js:1415:1
 Handler.prototype.process@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:932:23
 this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm ->
 resource://gre/modules/Promise-backend.js:813:7
 this.PromiseWalker.scheduleWalkerLoop/<@resource://gre/modules/Promise.jsm
 -> resource://gre/modules/Promise-backend.js:747:11
 }}}
 If you want to download the video as well via right-click and choose "Save
 Video as..." I get
 {{{
 ReferenceError: sm is not defined nsContextMenu.js:1346:11
 }}}
 Both is not happening without the patch for me and the download works in
 this case (although it is going over the catch-all circuit).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22343#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs