Re: [tor-bugs] #23487 [Core Tor/Tor]: Incorrect output on bad directory ownership

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23487: Incorrect output on bad directory ownership
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-backport 030-backport            |  Actual Points:
  031-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by catalyst):

 * status:  needs_review => merge_ready
 * reviewer:   => catalyst


Comment:

 Looks good to me.  I would suggest also not using the `pw_uid` for two
 different purposes in the same scope.  (This was a preexisting problem.)
 Possibly make them into separate variables like `pw_runner` and `pw_stat`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23487#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs