[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #22983 [Metrics/Library]: add a descriptor interface and implementation for web-logs

#22983: add a descriptor interface and implementation for web-logs
-----------------------------+-----------------------------------
 Reporter:  iwakeh           |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_information
 Priority:  Medium           |      Milestone:  metrics-lib 2.2.0
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------------

Comment (by iwakeh):

 Replying to [comment:33 karsten]:
 > Replying to [comment:31 iwakeh]:
 > > We agreed somewhere above to store only decompressed bytes in-memory.
 The method `public byte[] getCompressionType();` becomes obsolete in this
 case and will be removed.  Did I overlook any use for this method?
 >
 > Uhm, good question. A search on this page shows 80 matches of the word
 "compress". So, not sure if we agreed on this, but couldn't we store the
 ''compressed'' bytes in memory and ''decompress'' on-the-fly when they're
 requested? That would still not make a `getCompressionType()` mandatory,
 because the descriptor could as well store this type internally and not
 give it out. But, this is just off the top of my head, not based on re-
 reading the entire discussion above.

 Take a look at your comment:22 number 1; especially the cpu overhead would
 apply with storing compressed in-memory and decompressing when needed.

 >
 > However, another thought: ''adding'' a new method is a minor API change,
 whereas ''removing'' a method is a major API change. Maybe, if we can live
 without the method for now, let's try that.

 Yes, let's leave it out and store decompressed in-memory, but compressed
 on disk, but the latter rather is a topic for collector #22428 not
 metrics-lib.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs