Re: [tor-bugs] #23483 [Applications/Tor Browser]: Donation banner on about:tor page for 2017 campaign

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#23483: Donation banner on about:tor page for 2017 campaign
------------------------------------------------+--------------------------
 Reporter:  arthuredelstein                     |          Owner:  tbb-team
     Type:  defect                              |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:
Component:  Applications/Tor Browser            |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  crowdfunding, TorBrowserTeam201709  |  Actual Points:
Parent ID:  #23482                              |         Points:
 Reviewer:                                      |        Sponsor:
------------------------------------------------+--------------------------
Changes (by gk):

 * keywords:  crowdfunding, TorBrowserTeam201709R => crowdfunding,
     TorBrowserTeam201709
 * status:  needs_review => needs_revision


Comment:

 Another thing I found:
 {{{
     if (bannerDataJSON.length > 0) {
 }}}
 it's not guaranteed that you have `bannerDataJSON` at all at this stage.
 Can you add a check for that before you query its length?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23483#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs