[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23500 [Core Tor/Tor]: check-spaces.pl should check spaces after a comma when in functions.

#23500: check-spaces.pl should check spaces after a comma when in functions.
--------------------------+------------------------------------
 Reporter:  ewong         |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:  code-style    |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 I'm not sure if we want to add spaces after integers in structure
 initialisations, or in MOCK_IMPL declarations. But it seems ok to me. I'll
 leave it to nickm to make the final call.

 Also, have you checked that mass replace passes `make check-spaces`?

 I think this line is too long, and there may be others:
 {{{
         static char nil_bytes[16] = { [0]=0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
 0, 0, 0, 0, 0 };
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23500#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs