[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #23630 [Applications/Tor Browser]: Clarify README.HACKING
#23630: Clarify README.HACKING
------------------------------------------+----------------------
Reporter: tom | Owner: tbb-team
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Keywords:
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------------------+----------------------
> As an alternative, if you have your patch in a git repository, you can
> edit projects/firefox/config to change the git_url option to point to
> your git repository, and change the git_hash option to point to the
> commit you want to build. You will also need to comment the
> 'tag_gpg_id: 1' line (unless git_hash is pointing to a signed git tag).
I presume the current value of git_hash is a tag (and not a branch) right?
It'd be good to explain that.
Even better would be if we could build off branches. I guess my ideal
situaiton would be:
> As an alternative, if you have your patch in a git repository, you can
> edit projects/firefox/config to change the git_url option to point to
> your git repository.
>
> You can specify git_hash to build off a commit hash or tag, OR
> git_branch to build off a branch. (If both are specified, it is an
> error.) git_branch may be 'remotename/branchname' in which case the
> remote branch is `git fetch`-ed and then built; or 'branchname' in
> which case the local branch is `git checkout`-ed and then built.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23630>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs