[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23653 [Core Tor/Tor]: When accessing onion service with no fetchable descriptor, Tor sits around until timeout rather than hanging up
#23653: When accessing onion service with no fetchable descriptor, Tor sits around
until timeout rather than hanging up
----------------------------------+------------------------------------
Reporter: arma | Owner: asn
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version: Tor: 0.2.8.2-alpha
Severity: Normal | Resolution:
Keywords: regression backport? | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
----------------------------------+------------------------------------
Changes (by dgoulet):
* cc: dgoulet (removed)
* reviewer: => dgoulet
* status: needs_review => needs_revision
Comment:
All commits lgtm. Below is for one single commit `e278d84df5294872`:
* `if (base_conn->marked_for_close` is dead code because
`connection_list_by_type_state()` does NOT send you back marked for close
connections.
* I think this should be done outside of the for each loop:
`purge_hid_serv_request(identity_pk);`
* The other thing I'm thinking about is that I've always been annoyed by
the v2 warning that doesn't tell me _why_ tor had to give up on the
service. You think we can move the error code we get from
`fetch_v3_desc()` up to that function?
* Also, I think we could do this warning only once instead of for each
SOCKS connection? Else, we should try to put some identifier of the SOCKS
request in the log if we really want one per-socks. I often get those like
5 in a row because I had 5 SOCKS request for 5 different email account
going to the same .onion...
* `conns` memory leaks, it needs to be `smartlist_free()`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23653#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs