[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23688 [Applications/Tor Browser]: Add GitLab CI script
#23688: Add GitLab CI script
--------------------------------------+-----------------------------------
Reporter: krichter | Owner: tbb-team
Type: enhancement | Status: needs_information
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+-----------------------------------
Changes (by boklm):
* status: new => needs_information
Comment:
Some comments and questions about this patch:
- the `before_script` is downloading some deb file and installing them
without checking their checksum, so we don't really know what we are
installing.
- where is this gitlab-ci file going to be used? I think doing a full
rebuild of `tor-browser-bundle.git` on each commit is going to use a lot
of resources.
- why is the script first starting a build with LXC, and after doing that
starting an other one in the vagrant directory?
- if I understand correctly, the `image: ubuntu:zesty` line means that the
script is run inside a docker container. Does creating LXC containers or
Virtualbox VMs with vagrant work inside a docker container?
- starting with version 7.5a5, we are now using `rbm` and `tor-browser-
build.git` rather than `gitian` and `tor-browser-bundle.git` for new
development.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23688#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs