[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23663 [Applications/Tor Browser]: ESR52 codebase is incompatible with anything below Universal C Runtime (CRT) in Windows
#23663: ESR52 codebase is incompatible with anything below Universal C Runtime
(CRT) in Windows
--------------------------------------+--------------------------
Reporter: cypherpunks | Owner: tbb-team
Type: defect | Status: closed
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Major | Resolution: invalid
Keywords: tbb-security | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+--------------------------
Changes (by gk):
* status: new => closed
* resolution: => invalid
Comment:
Replying to [comment:8 cypherpunks]:
> Replying to [comment:7 gk]:
> > Replying to [comment:6 cypherpunks]:
> > > Replying to [comment:5 gk]:
> > > > Replying to [comment:4 cypherpunks]:
> > > > > Don't you see that Jacek's patch activated compat shims for
mingw? They were removed later as useless for UCRT (but needed for <=
`msvcr120.dll`!).
> > > >
> > > > Oh, okay. You are just concerned about https://hg.mozilla.org
/mozilla-central/rev/5680a55b2ec1?
> > > Of course, no.
> > > > I thought about cases in the other patches as well as you posted
them in the description. But as I said they are guarded by `_MSC_VER`
defines which are not used by mingw-w64 anyway.
> > > But they should have been adapted to mingw where it's about CRT
bugs.
> >
> > Why? Removing those patches does not change anything with respect to
mingw-w64. Those code parts did not get used for it before code removal
either.
> Because you're using CRT, obviously. Patches for MSVC don't change
anything, but for CRT do, e.g. https://hg.mozilla.org/mozilla-
central/rev/398f38361dc2#l10.10
That one does not affect us either. We don't use jemalloc in mingw-w64
Windows builds and `MOZ_CRT` is not defined either. Thus, removing this
part is not mingw-w64 related.
So, if you have concrete things that are bugs and are affecting us, please
report them. I think the ticket as-is is invalid.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23663#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs