[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #27403 [Applications/Tor Browser]: The onboarding bubble does not show up in the release candidate for Tor Browser
#27403: The onboarding bubble does not show up in the release candidate for Tor
Browser
--------------------------------------+------------------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: needs_review
Priority: Immediate | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: TorBrowserTeam201808R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------------+------------------------------
Comment (by mcs):
Replying to [comment:4 gk]:
> Thanks! So, we might have two different issues here (which could easily
be related): your fix (and commenting out the aboutTor.css pieces)
"solves" the problem in subsequent Tor Browser starts but not on first
start. On first start for some interesting reason `_resizeUI()` is never
called. (I don't see your debug output in my logs in that case but do in
the following Tor Browser starts)
I debugged this a little more. The two problems seem to be unrelated. What
is happening in the first run case is that the onboarding extension is not
yet listening for load events when about:tor loads. The relevant code is
in `browser/extensions/onboarding/bootstrap.js`. The `browser-delayed-
startup-finished` observer notification is not received soon enough. I
tried switching to `final-ui-startup` but that did not help.
Unfortunately, I am out of time again for now.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27403#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs