[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27247 [Core Tor/Tor]: Clients are using RAM for cached_dir_t



#27247: Clients are using RAM for cached_dir_t
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #27243                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):

 * owner:  ahf => nickm
 * status:  assigned => accepted


Comment:

 This turns out to be an extremely simple patch, if we try to do the simple
 version of this code.  See branch ticket27247 ; PR at
 https://github.com/torproject/tor/pull/310

 Teor, could you review this?  It reverts part of a commit that you made in
 2016, and I'm hoping you'll be able to tell me if I'm about to break
 something here.

 I've opened #27563 for a fancier way to save this memory on directory
 caches.  The remaining ticket (#27244) is not in fact redundant: we could
 use mmap here instead of read_file_to_string, but we'd need to refactor
 other things.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27247#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs