[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27728 [Core Tor/Tor]: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks -flto compilation

#27728: Signature mismatch for crypto_strongest_rand() in ed-donna code breaks
-flto compilation
--------------------------+------------------------------------
 Reporter:  Hello71       |          Owner:  nickm
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 Okay -- I've had to install GCC 8.2 locally, and after a bit I've
 successfully reproduced this.  So I don't forget, the configuration line I
 used was:
 {{{
 ./configure CC=/opt/gcc-8.2/bin/gcc CFLAGS='-O3 -flto' LDFLAGS='-flto' \
     AR=/opt/gcc-8.2/bin/gcc-ar \
     RANLIB=/opt/gcc-8.2/bin/gcc-ranlib \
     NM=/opt/gcc-8.2/gcc-nm
 }}}

 I've added a simple fix as branch `bug27728`, with PR at
 https://github.com/torproject/tor/pull/354 .

 I'm seeing a few other GCC 8.2 warnings on the source code -- I'll try to
 check whether they're LTO only.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27728#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs