#27799: Split routerlist.c and dirserv.c into smaller modules
--------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: task | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet | Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):
* status: needs_review => needs_revision
Comment:
I think this is great. Some questions:
I would be consistent on a file name that have `_fmt` for which it should
be either at the start or end, doesn't matter, just that we have the same
standard for all files.
{{{
fmt_serverstatus.c
routerstatus_fmt.c
}}}
The other thing that confuses me is:
{{{
* recv_descs.c handles fingerprint files and processing incoming
routerinfos that relays upload to us
}}}
The `recv_descs.c` file name seems to suggest to me that it is about
receiving descriptors, not "handling" them per se. I would suggest using
something around the lines of `handle_desc.c` or using the term "decision"
somehow to show that the code in that file is about decision making of
descriptors, not parsing, not I/O, not storing or "receiving".
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27799#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________ tor-bugs mailing list tor-bugs@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs