[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31567 [Applications/Tor Browser]: NS_tsnprintf() does not handle %s correctly on Windows
#31567: NS_tsnprintf() does not handle %s correctly on Windows
-------------------------------------------------+-------------------------
Reporter: mcs | Owner: gk
Type: defect | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Critical | Resolution:
Keywords: ff68-esr, tbb-9.0-must-alpha, | Actual Points:
TorBrowserTeam201908R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:33 mcs]:
> r=mcs
> The patch looks good to me, and most importantly it seems to fix the
problem. Maybe Richard should take a look at the mingw patches too, but I
think we are good here.
Sounds good to me. I'll leave the ticket open to wait for Richard's
feedback here but merged the fix to `master` (commit
a479eeb424496b781d7ea9cf7b2d9a6404d7c32f) to have it in our next nightly
builds (there aren't that many before the first alpha needs to get out).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31567#comment:34>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs