[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31558 [Metrics/CollecTor]: Process bridge pool assignments again

#31558: Process bridge pool assignments again
-------------------------------+------------------------------
 Reporter:  karsten            |          Owner:  metrics-team
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:  irl                |        Sponsor:
-------------------------------+------------------------------

Comment (by notirl):

 Status: -> needs_revision_maybe

 There is not another "Processor" class in CollecTor. We already have:
 Annotation, Builder, Checker, Configuration, Criterium, Downloader,
 Exception, Hook, Json, Key, Main, Manager, Map, Metadata, Parser,
 Persistence, Reader, Scheduler, Type, Utils, Weblogs, Writer. That's a lot
 of concepts, can we reuse one for this? (I put a table later in this
 comment with the number of times each noun appears in the codebase.)

 The startProcessing() function is huge and there are no tests for it. ):
 This also makes the review difficult. I'm relatively confident that we're
 not going to accidentally publish a load of raw bridge fingerprints but as
 to the correctness of the code, and the reliability, I'm less confident.

 Saying this, if this huge function was working before then I'm happier
 about adding it back now and then filing tickets to break it down and add
 tests later. At least then it's not completely unknown new code.

 {{{
 num  noun
    1 Annotation
    1 Builder
    1 Checker
    1 Configuration
    2 Criterium
    3 Downloader
    1 Exception
    1 Hook
    1 Json
    1 Key
    2 Main
    1 Manager
    1 Map
    1 Metadata
    2 Parser
   15 Persistence
    3 Reader
    1 Scheduler
    1 Type
    1 Utils
    1 Weblogs
    2 Writer
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31558#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs