[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()
#31571: Add the tor version and a newline to raw_assert()
-------------------------------------------------+-------------------------
Reporter: teor | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: diagnostics, 042-should, android, | Actual Points: 0.1
macos, 035-backport, 040-backport, |
041-backport |
Parent ID: #31570 | Points: 0.1
Reviewer: nickm | Sponsor:
| Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_revision => needs_review
Comment:
Replying to [comment:1 teor]:
> See my pull request:
> * 0.3.5: https://github.com/torproject/tor/pull/1277
I changed the code to use strlcpy() and strlcat() rather than strncpy()
and snprintf(), and pushed an updated branch.
> The remaining merges are clean, you can see the test branches bug31571_*
at:
> https://github.com/teor2345/tor/branches
I also added a refactor that simplifies the code, and a comment fix:
* master: https://github.com/torproject/tor/pull/1287
I put them on master, because they don't need to be backported.
I opened #31594 for the "close fds before abort" follow-up.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31571#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs