[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31571 [Core Tor/Tor]: Add the tor version and a newline to raw_assert()

#31571: Add the tor version and a newline to raw_assert()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  diagnostics, 042-should, android,    |  Actual Points:  0.1
  macos, 035-backport, 040-backport,             |
  041-backport                                   |
Parent ID:  #31570                               |         Points:  0.1
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:1 teor]:
 > See my pull request:
 > * 0.3.5: https://github.com/torproject/tor/pull/1277
 >
 > The remaining merges are clean, you can see the test branches bug31571_*
 at:
 > https://github.com/teor2345/tor/branches

 It turns out that we can't use strlcpy() in lib/torerr, because strlcpy()
 is defined in lib/string on some platforms, and lib/string depends on
 lib/torerr.

 I added a commit that checks the return values of snprintf() and strncpy()
 instead.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31571#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs