[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31598 [Applications/Tor Browser]: Properly enable letterboxing (again)

#31598: Properly enable letterboxing (again)
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  TorBrowserTeam201909, tbb-9.0-must-  |  Actual Points:
  alpha                                          |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by acat):

 Mmm, actually I thought about that, but not sure how I tested that I
 thought letterboxing was not being enabled instantly, just on a new
 window.

 In any case, here is a revised patch:
 https://github.com/acatarineu/torbutton/commit/31598+2. Now the resize
 listener is always enabled and checking the pref when it's called. Being
 strict, this still has the issue that a user with the window already
 maximized changing letterboxing pref will not get any notification, since
 these are only shown on window resize right now. Do you think we should
 also handle those cases?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31598#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs