[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31532 [Core Tor/Tor]: Use ptrdiff_t for struct_member_t.offset, etc

#31532: Use ptrdiff_t for struct_member_t.offset, etc
-----------------------------------------+---------------------------------
 Reporter:  nickm                        |          Owner:  nickm
     Type:  defect                       |         Status:  assigned
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.4.2.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Trivial                      |     Resolution:
 Keywords:  network-team-roadmap-august  |  Actual Points:
Parent ID:  #29211                       |         Points:
 Reviewer:                               |        Sponsor:  Sponsor31-can
-----------------------------------------+---------------------------------

Comment (by nickm):

 I have made a branch to clean up all the places I could find in our code
 that should be using `ptrdiff_t`.  I made it by first changing the three
 points listed in the description of this ticket, and then by grepping for
 `off_t`, `offsetof`, and `STRUCT_VAR_P`.

 Please let me know if you think this should be split into separate PRs or
 tickets.

 The branch is `ticket31532`; the PR is
 https://github.com/torproject/tor/pull/1291 .  I'll put this in
 needs_review once CI passes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31532#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs